WyriHaximus.net Support Forums

[atcs2003]

somebody help me

everthing seems to be ok except for the code it gives is not right and not working??

<a href="http://atcs2003.com:80/newf/mods/toplist_mod/dload.php?id=4"><img src="http://atcs2003.com:80/newf/mods/toplist_mod/image.php?id=4" style="border:0px;" /></a>

why does it have newf in there?

my forum is

http://atcs2003.com/community

have it installed here
http://atcs2003.com/community/toplist.php

[WyriHaximus]

somebody help me

everthing seems to be ok except for the code it gives is not right and not working??

<a href="http://atcs2003.com:80/newf/mods/toplist_mod/dload.php?id=4"><img src="http://atcs2003.com:80/newf/mods/toplist_mod/image.php?id=4" style="border:0px;" /></a>

why does it have newf in there?

my forum is

http://atcs2003.com/community

have it installed here
http://atcs2003.com/community/toplist.php

The toplist mod checks the board config for the right location if yours is set to atcs2003.com:80/newf/ rather then atcs2003.com:80/community/ you can find these settings in the ACP -> Server Settings -> Server URL settings

[WyriHaximus]

Hmm found a bug accouring when people come to your site. Gonne fix that as soon as I get home and try to clear the incoming screen up a bit .

[atcs2003]

hahaha i don't know how that got set to that but i changed it to community and now it works thanks so much


one more question

when somebody clicks on the vote button it takes them to the page with
Continue to this site >>> and there banner and comment page? shouldn't it take them to a thank you page or back to the toplist main index part?

if not where can i edit Continue to this site >>> and add below that link Continue to the Toplist Index >>>>

Hmm found a bug accouring when people come to your site. Gonne fix that as soon as I get home and try to clear the incoming screen up a bit

sorry didn't see that post are we talking about the same thing?

[WyriHaximus]

hahaha i don't know how that got set to that but i changed it to community and now it works thanks so much


one more question

when somebody clicks on the vote button it takes them to the page with
Continue to this site >>> and there banner and comment page? shouldn't it take them to a thank you page or back to the toplist main index part?

if not where can i edit Continue to this site >>> and add below that link Continue to the Toplist Index >>>>

Hmm found a bug accouring when people come to your site. Gonne fix that as soon as I get home and try to clear the incoming screen up a bit

sorry didn't see that post are we talking about the same thing?

Yeah we are talking about the same thing . It's exactly the same page as when you view the site details only the link under the text is different. Gonne change it into the suggested text. (Maybe change it in "Vote for this site" cause the in_hit counter isn't updated untill you click the link.) And fix the broken link .

[atcs2003]

any word on a fix for my broken link and redirect part?

or a quick fix i could do

[WyriHaximus]

any word on a fix for my broken link and redirect part?

or a quick fix i could do

Compiling it right now for you .

[WyriHaximus]

Ok in language/en/common.php add this to the rest of the entries:

Code: Select all

'TOPLIST_VOTE_FOR_SITE' => 'Vote for this site',


In styles/prosilver/template/toplist_view_site.html FIND:

Code: Select all

                           <a id="proceedtositelinkseccond" href="{U_URL_SEO}" target="_blank">
                                        <!-- IF S_OUT -->
               {L_TOPLIST_PROCEED_TO_SITE}


REPLACE, WITH:

Code: Select all

                           <a id="proceedtositelinkseccond" href="{U_URL_SEO}" <!-- IF S_OUT -->target="_blank"<!-- ENDIF -->>
                                        <!-- IF S_OUT -->
               {L_TOPLIST_PROCEED_TO_SITE}
                                        <!-- ELSE -->
                                        {L_TOPLIST_VOTE_FOR_SITE}
                                        <!-- ENDIF -->


In mods/toplist_mod/core.class.php FIND:

Code: Select all

            switch($w)
            {
               case 'out':
                  $url = $phpbb_root_path . 'mods/toplist_mod/go.' . $phpEx . '?id=' . $id . '&mode=out&uniqid=' . $hash['uniqid'] . '&hash=' . $hash['hash'];
                  $url_seo = $row['site_url'];
                  $blank_target = true;
                  break;
               case 'in':
                  $url_seo = $url = $phpbb_root_path . 'mods/toplist_mod/dload.' . $phpEx . '?id=' . $id . '&mode=in&uniqid=' . $hash['uniqid'] . '&hash=' . $hash['hash'];
                  $blank_target = false;
                  break;
               default:
                  die('xxx');
                  break;
            }


REPLACE, WITH:

Code: Select all

            switch($w)
            {
               case 'out':
                  $url = $phpbb_root_path . 'mods/toplist_mod/go.' . $phpEx . '?id=' . $id . '&mode=out&uniqid=' . $hash['uniqid'] . '&hash=' . $hash['hash'];
                  $url_seo = $row['site_url'];
                  $blank_target = true;
                        $out_template_switch = true;
                  break;
               case 'in':
                  $url_seo = $url = $phpbb_root_path . 'mods/toplist_mod/dload.' . $phpEx . '?id=' . $id . '&mode=in&uniqid=' . $hash['uniqid'] . '&hash=' . $hash['hash'];
                  $blank_target = false;
                        $out_template_switch = false;
                  break;
               default:
                  die('xxx');
                  break;
            }


FIND:

Code: Select all

            $template->assign_vars(array(
               'SITE_BANNER' => $phpbb_root_path . 'mods/toplist_mod/image.' . $phpEx . '?mode=inside&id=' . $id . '&hash=' . $hash['hash'] . '&uniqid=' . $hash['uniqid'],


AFTER, ADD:

Code: Select all

                    'S_OUT' => $out_template_switch,


This should atleast fix the link text. Still looking into a few URL issue, but can't give you a fix right now cause of the code cleanup and normalization . I also attached an updated go.php and dload.php for in mods/toplist_mod/ those might fix it not sure tho.

[atcs2003]

that seem to fix the redirect page to Vote for this site but when you click on it the link still broken...
Is that a bug you have or something just wrong on my site?

[WyriHaximus]

that seem to fix the redirect page to Vote for this site but when you click on it the link still broken...
Is that a bug you have or something just wrong on my site?

Don't have a fix for it right away, this can be used as work around. Create a file toplist.php in mods/toplist_mod

Code: Select all

<?php
header('Location: ../../toplist.php');
?>


It's not a good solution but it works.

[atcs2003]

yeap that seems to work

[WyriHaximus]

Great, time to finish off the new ACP .